Number comparison problem

[bthibault]

Doug,

Maybe i'm doing something wrong,

But when I run rule matching on this expression, matching fails

"79.00" == 79 .. in JSFiddle ofcourse this evaluates to true.

Rule matching is working for this however...

"79.00" <= 100 -> true

It seems like that number comparison maybe getting translated somewhere down the stack.

Thanks

[doug-martin]

Nools uses a strict equals so your "79.00" will not === 79 however I do believe you can add parseInt("79.00", 10) == 79 but I have not tried it I will look at that a little later today. I would be open for a pull request that differentiates between ==, != === and !==

[bthibault]

Well really what I"m passing in is

p.price == 79

so I can't really do: parseInt(p.price, 10 )

at that the same time, I'm not sure that loosening the strict matching is an answer either, people can run into issues if they don't know what they're doing.

Let me know where I should I look, and I can take a gander. Looks like some of this is happening in contraints.js ... i'm not sure I can follow it w/ out a sequence diagram or a specific instructions but I can look nonetheless.

[bthibault]

Also this is why I hate dynamic type languages 🔢 , makes everything more complicated

[bthibault]

Doug,

Let me know if you had a chance to look at this or where I would update this at. This is a blocker as I'm about to roll Nools out into production.

[bthibault]

Okay I got this working by a hack:

parseInt didn't work, but i was able to do this:

// p.price = '79.00'

(p.price * 1) == 79 // true

It makes sense that 'price' should be a float to begin with... but part of what I'm using Nools for is data normalization so its important that I get it working from the nools end. Anyway were good for now

[doug-martin]

Ok I added ===, and !== to v0.3.0 I did this since we are using javascript and I this hasnt just tripped you up but other people also. I wrote the constraints parser to be as close to Javascript as possible and the lack of differentiation of strict equality is something that I should have had since the beginning.

I hope this helps.

-Doug

[bthibault]

Thanks Doug.