Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding commandline options to list boards and ports #27

Merged
merged 4 commits into from
Nov 16, 2015

Conversation

makenai
Copy link
Contributor

@makenai makenai commented Oct 16, 2015

Closes #1

Added commandline options to list boards and ports. Started adding some test boilerplate to build upon and tests for board detection.

Let me know if any of the output or refactoring isn't up to spec and I can fix it up.

@noopkat
Copy link
Owner

noopkat commented Oct 16, 2015

@makenai thank you for this! These are really nice ideas/additions. I have some feedback for this PR, but need a little time to write it up. Stay tuned!

You can list available USB ports programmatically using the the `listPorts` method:

```javascript
Avrgurl.listPorts(function(err, ports) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling of Avrgirl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh!

@makenai
Copy link
Contributor Author

makenai commented Oct 27, 2015

Thanks for the feedback, Suz! Give me a few days and I'll address the issues.

@makenai
Copy link
Contributor Author

makenai commented Nov 11, 2015

Sorry it took me a bit longer than I thought to get back to this. I've incorporated your suggested changes and rebased against master. How does this look?

@makenai
Copy link
Contributor Author

makenai commented Nov 13, 2015

@noopkat Patch up to preserve the exit status - thanks for explaining!

@noopkat noopkat merged commit f9f10a3 into noopkat:master Nov 16, 2015
@noopkat
Copy link
Owner

noopkat commented Nov 16, 2015

Thanks @makenai! Merged and will publish soon with some other additions (like CI / new styleguide stuff and readme changes).

Just a small note - for now I have consolidated the list CLI method to just output the verbose version only. The reasoning is that I'd prefer to speak to some active avrgirl-arduino users first and gather some requirements and ideas from them first before setting anything in stone for this. I'm sorry to give you the runaround for that JSON object in the end, I hope you understand.

I really appreciate these contributions though, so thanks again 👏

@makenai
Copy link
Contributor Author

makenai commented Nov 16, 2015

Thank you, Susan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add CLI features
2 participants