Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message templates. Support HTML body #169

Closed
mariannk opened this issue Jan 15, 2016 · 2 comments
Closed

Message templates. Support HTML body #169

mariannk opened this issue Jan 15, 2016 · 2 comments
Assignees
@RomanovM
Labels
bug
Milestone
Version 3.90

Comments

@mariannk
Copy link

mariannk commented Jan 15, 2016 •
edited by AndreiMaz

We should support "body" HTML tag when editing message templates (rich editor) similar to how it's done for campaigns. But the issue is that when we have multiple languages, then "body" HTML tag is automatically added to the editors for other languages (other tabs). And that's why they are saved as localized values (as not empty) - so you cannot have empty value for HTML templates for other languages

Also see http://www.nopcommerce.com/boards/t/38848/nopcommerce-380-roadmap-and-estimated-release-date-lets-discuss.aspx?p=6#160458

see #1913 (when done this work item can be closed)
@mariannk mariannk added this to the Version 3.80 milestone Jan 15, 2016
@odises
Copy link
Contributor

odises commented Jan 31, 2016

What if we consider
<!DOCTYPE html>\r\n<html>\r\n<head>\r\n</head>\r\n<body>\r\n\r\n</body>\r\n</html>
as empty in server side, and set the Body value to null manually.
Does it look like a workaround?

@AndreiMaz
Copy link
Member

It's more a workaround. I don't like this approach. There should be more elegant way to fix it

@AndreiMaz AndreiMaz self-assigned this Jun 8, 2016
@AndreiMaz AndreiMaz removed their assignment Jun 21, 2016
@AndreiMaz AndreiMaz modified the milestones: Version 4.00, Version 3.80 Jul 18, 2016
@AndreiMaz AndreiMaz modified the milestone: Version 4.00 Jul 27, 2016
@AndreiMaz AndreiMaz modified the milestone: Version 3.90 Jul 28, 2016
@AndreiMaz AndreiMaz mentioned this issue Dec 1, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanovM RomanovM

Labels
bug
Projects
None yet
Milestone
Version 3.90
Development

No branches or pull requests
4 participants
@odises @AndreiMaz @mariannk @RomanovM