Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter and sort by price ignores tier prices and discounts #2078

Closed
AndreiMaz opened this issue Jan 31, 2017 · 1 comment
Closed

Filter and sort by price ignores tier prices and discounts #2078

AndreiMaz opened this issue Jan 31, 2017 · 1 comment

Comments

@AndreiMaz
Copy link
Member

AndreiMaz commented Jan 31, 2017

We have to update [ProductLoadAllPaged] stored procedure. But it can significantly decrease performance. Maybe, we should do it configurable (pass as a SP parameter, disabled by default).

Anyway this stored procedure also ignores discounts. And it's just not possible to implement them in the stored procedure because we can have discount requirement plugins that cannot be moved to the stored procedure.

So the question is what should we do here? Implement tier prices only?

also see: http://www.nopcommerce.com/boards/t/45996/price-range-for-special-customers.aspx

@AndreiMaz AndreiMaz modified the milestone: Version 4.00 Mar 12, 2017
@AndreiMaz AndreiMaz changed the title Filter by price ignores tier prices Filter by price ignores tier prices and discounts Aug 24, 2017
@AndreiMaz AndreiMaz assigned AndreiMaz and unassigned AndreiMaz Aug 29, 2017
@AndreiMaz AndreiMaz changed the title Filter by price ignores tier prices and discounts Filter and sort by price ignores tier prices and discounts Sep 8, 2017
@AndreiMaz AndreiMaz removed this from the Version 4.00 milestone Sep 8, 2017
@AndreiMaz AndreiMaz removed their assignment Sep 8, 2017
@AndreiMaz AndreiMaz added this to the Version 4.10 milestone Jan 1, 2018
@AndreiMaz AndreiMaz removed this from the Version 4.10 milestone Jun 22, 2018
@AndreiMaz
Copy link
Member Author

After some consideration we've decided not to implement this functionality out of the box because it's a too specific requirement. As per the description it's not possible to implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant