Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor so that plugins can encrypt/decrypt settings.txt #2589

Closed
mmccann-umph opened this issue Sep 27, 2017 · 5 comments
Closed

Refactor so that plugins can encrypt/decrypt settings.txt #2589

mmccann-umph opened this issue Sep 27, 2017 · 5 comments

Comments

@mmccann-umph
Copy link

Would a pull request be accepted that refactors the code such that DataSettingsManager is injected rather than hardcoded.

Doing this would allow the creation of a plugin that encrypts/decrypts settings.txt, enhancing security by no longer storing an unencrypted connection string with username and password on the file system in plain text.

Thank you!

@AndreiMaz
Copy link
Member

@mmccann-umph sure. please contribute.

@mmccann-umph
Copy link
Author

Will do, thanks!

@a-patel
Copy link
Contributor

a-patel commented Sep 29, 2017

suggest you (@mmccann-umph and @AndreiMaz) to use json (settings.json) file instead of text file.

@AndreiMaz
Copy link
Member

@a-patel thanks! we've also thought about it - #2597

@AndreiMaz
Copy link
Member

After some discussion decided not to implement it out of the box. IT can cause issues when a new data protecion keys are generated, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants