Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model collection events #2680

Closed
AndreiMaz opened this issue Oct 24, 2017 · 1 comment
Closed

Model collection events #2680

AndreiMaz opened this issue Oct 24, 2017 · 1 comment
Labels
on hold / maybe wont refactoring / source code

Comments

@AndreiMaz
Copy link
Member

Now it works but it took us some time to see that we could not have IConsumer<ModelPrepared<IEnumerable>> but it should be IConsumer<ModelPrepared<IEnumerable>> instead (then we saw the comment in the code that it was intentional) and need to cast it to the concrete type in the HandleEvent method.

Source: https://www.nopcommerce.com/boards/t/48672/nopcommerce-40-bug-fixes-and-improvements.aspx?p=5#195100
@AndreiMaz AndreiMaz added this to the Version 4.00 milestone Oct 24, 2017
@AndreiMaz AndreiMaz removed this from the Version 4.00 milestone Oct 25, 2017
@AndreiMaz AndreiMaz added this to the Version 4.10 milestone Dec 4, 2017
@AndreiMaz AndreiMaz removed this from the Version 4.10 milestone Jun 25, 2018
@AndreiMaz
Copy link
Member Author

After some consideration we've decided to leave the current implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
on hold / maybe wont refactoring / source code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreiMaz @skoshelev