Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Assembly Versions #6654

Closed
Manuel-Innovapps opened this issue Mar 16, 2023 · 4 comments
Closed

Update Assembly Versions #6654

Manuel-Innovapps opened this issue Mar 16, 2023 · 4 comments

Comments

@Manuel-Innovapps
Copy link
Contributor

nopCommerce version: 4.60.x

Steps to reproduce the problem:
The assembly versions still show 4.5.0.0, see

in example

@AndreiMaz
Copy link
Member

@Manuel-Innovapps Thanks a lot for suggestion. We missed it in 4.60. But we'll do it in 4.70 release

@AndreiMaz AndreiMaz closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2023
@noptools
Copy link

Why closed? I still see in current repo

...
**4.5.**0.0

@AndreiMaz
Copy link
Member

@noptools We cannot update in the already released 4.60.X because it'll break third-party plugins. So we'll leave it as "4.5" in versions 4.60.X. But we'll fix it in the next versions

@biggik
Copy link

biggik commented Feb 19, 2024

May I suggest that you start using a Directory.Build.props (caseing of file name is important) file next to your .sln file
That way you can move all the common elements, even most of the current elements to this file and can remove them from all your .csproj files.
This will also enable to to start versioning all your DLLs - your plugins are all 1.0.0.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants