reflection warning in epsilon util, fixes #230 #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just opened another PR #238 - It will be better to get that one in first so that you will be able to see all the tests that run in your ci workflow on the pull request before needing to merge. Just wanted to add another little useful feature you may enjoy (Especially if you prefer github notification for management) https://joeprevite.com/auto-assign-pull-requests-github. This will allow any new PR's on the repo to be assigned to you so you can be notified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to first say thank you for your hard work on this library. I started playing around with it today and it's awesome!
Fixed issue with reflection warning reported in #230.
I added
bbreader conditionals before thecljones which prevent us from trying to dynamically load the class.Babashka Reader conditionals will read
bbbeforeclj.I added cache in gitignore which clj-kondo & lsp-lisp use and is safe to ignore.
I added calva in gitignore for anyone who codes using calva on VSCode.
Please let me know if you have any questions or you want me to make any changes.