-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web API support #20
Comments
Nop-templates Web Api plugin looks ok, but I attended the devdays this year and spotted various culprits in their implementation:
Okay gonna stop rambling on now... sorry for that, but I'm an REST API purist when comes to stuff like this. Another note I believe you might benefit more from introducing something like Web Hooks instead of exposing the API. |
@suddenelfilio Thanks a lot for your feedback. Could you please copy and post it at https://github.com/SevenSpikes/nopCommerce/issues. This way Boyko will see it |
Thank you for your feedback! Please see my comments below:
In the request above only the product name will be updated and nothing will be deleted. If you want to delete the product images then you need to explicitly specify the Images property like this: PUT /api/products/5 The request above will delete all product images for this product. Actually to fully manage the product images there should be separate endpoints i.e (/api/products/{#id}/images) but they are still not implemented. 3. Agree. There should be a setting in the API plugin that will control if the returned images should be in Base64 format or just a link to the image i.e "attachment" or "src". I will create an issue for this.4. As I said on the conference - the API design is a never ending debate :) So we better choose one naming convention and stick with it. I think the majority of APIs use snake_case and that is why we decided to use this one. Regarding the OrderItems, I agree with you. It could be simply Items. We did this mechanically because we have a separate controller called OrderItemsController and also OrderItemDTO etc. and that is why we made the routes with OrderItems. I will create a new issue to correct this. Regarding the paging/filtering/sorting, it is all done on the DB level. To be honest the Customers is the only area that I really don't like how we have implemented. But if you have a chance to take a look at the code and give us feedback will be much appreciated. WebHooks - this is really what the next step for the API plugin should be. Let's first make sure the rest of the things are stable and working and we will do this one as well. I will create an issue for this. Thank you again! |
@AndreiMaz and @poyker, My team works with nopCommerce and we're very keen to begin using the API for integration projects, so I have three questions that I'm hoping you can answer please:
I need to make a decision on whether to begin working with the API quite quickly, so would really appreciate your feedback. Many thanks, Ali |
@AndreiMaz, I see this work item has just been closed, please can you provide an update on the status of the API? Many thanks, Ali |
Great - thanks @AndreiMaz! Please can you confirm the answers to questions 2 & 3 in my above post if possible? |
@alijunkison please address these questions to "poyker" (original developer of this great plugin)! |
"Most serious e-commerce businesses doesn't use ecommerce solution alone. They also use a decent crm"... omg exactly the phrase I was looking for <3 (y) |
Most serious e-commerce businesses doesn't use ecommerce solution alone. They also use a decent accounting, crm, inventory, order management, support and operations management solutions which needs to work very closely with the ecommerce solution. However, adding all those features to the nopCommerce is out of the scope definitely... but giving a decent set of API for integration will be very helpful for all service providers and retailers using nopCommerce.
This will greatly enhance adoption of nopCommerce for the serious retailers as most of them will use it. Moreover, providing it also enables solution providers to come up with generic plugins for example, integration for salesforce or vtiger crm, integration for quickoffice or openerp or any other solution!
See http://www.nopcommerce.com/boards/t/31212/nopcommerce-350-roadmap-and-estimated-release-date-lets-discuss.aspx#127120
UPDATE: nop-templates.com are going to contribute some great implementation soon
https://github.com/SevenSpikes/nopCommerce/tree/Web-Api-3.70
and
https://github.com/SevenSpikes/nopCommerce-Api-SampleApplication
RESULT IS AVAILABLE AT http://www.nopcommerce.com/p/2464/api-plugin.aspx
The text was updated successfully, but these errors were encountered: