Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The bot does not seems to work when a generated file is committed #35

Closed
courentin opened this issue Apr 1, 2021 · 2 comments
Closed

The bot does not seems to work when a generated file is committed #35

courentin opened this issue Apr 1, 2021 · 2 comments

Comments

@courentin
Copy link

I'm not sure it's the expected behaviour but as soon there is a generated file in a PR (marked as linguist-generated=true in .gitattributes) the bot does not add/update a label.

When I remove the file from the PR, it adds/updates the label again.
@noqcks
Copy link
Owner

noqcks commented Jul 23, 2021

I can't seem to reproduce this behaviour. I created this PR to test and a label was added successfully. Let me know if you can still reproduce.

My gut feeling is that this issue was fixed when we fixed a package in the generated package: noqcks/generated@a5e25fa

@courentin
Copy link
Author

It seems to work indeed! Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@noqcks @courentin