Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar #365

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Fix grammar #365

merged 2 commits into from
Apr 27, 2023

Conversation

smoy
Copy link
Contributor

@smoy smoy commented Apr 27, 2023

What changed?

Fix grammar

Rationale

Fix grammar from suggestion

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified

@smoy smoy self-assigned this Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -14.16 ⚠️

Comparison is base (9e4b14d) 84.26% compared to head (ef1699b) 70.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #365       +/-   ##
===========================================
- Coverage   84.26%   70.11%   -14.16%     
===========================================
  Files          98       98               
  Lines       10620    10620               
===========================================
- Hits         8949     7446     -1503     
- Misses       1671     3174     +1503     
Flag Coverage Δ
functional_tests ?
functional_tests_config_discovery ?
unit_tests 70.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 46 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@perpil perpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smoy smoy added the documentation Improvements or additions to documentation label Apr 27, 2023
@smoy smoy merged commit 820a4b6 into main Apr 27, 2023
@smoy smoy deleted the fix/fix-grammar branch April 27, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants