Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker alias to allow AWS SSO + additional clarity #368

Merged
merged 1 commit into from
May 2, 2023

Conversation

datfinesoul
Copy link
Contributor

What changed?

  • Updated the alias in the documentation

Rationale

  • -e HOME was required in order to make AWS SDK figure out where the .aws/sso/cache folder lives
  • -e AWS_PROFILE was changed to pick up the current profile when running iambic as an alias
  • <local_dir\> was changed for clarity
  • -v ${HOME}/.aws:/app/.aws:ro was changed since write access to this directory should not be required

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified

@CLAassistant
Copy link

CLAassistant commented May 2, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@castrapel castrapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Keep 'em coming. Suggestion for read-only volume mount 🏅

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -10.24 ⚠️

Comparison is base (b45c61f) 85.25% compared to head (cdb12c7) 75.02%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #368       +/-   ##
===========================================
- Coverage   85.25%   75.02%   -10.24%     
===========================================
  Files          98       98               
  Lines       10624    10624               
===========================================
- Hits         9058     7971     -1087     
- Misses       1566     2653     +1087     
Flag Coverage Δ
functional_tests ?
functional_tests_config_discovery ?
unit_tests 75.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 47 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@castrapel castrapel merged commit 18e1024 into noqdev:main May 2, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants