Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example on how condition is used in policy #371

Merged
merged 3 commits into from
May 2, 2023

Conversation

smoy
Copy link
Contributor

@smoy smoy commented May 2, 2023

What changed?

  • Add example on how condition is used in policy

Rationale

  • Condition is not the easiest statement to write. Let's add an example and reference to AWS documentation.

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified

I made an equivalent template to be planned by IAMbic: noqdev/iambic-templates-examples#9

@smoy smoy added the documentation Improvements or additions to documentation label May 2, 2023
@smoy smoy self-assigned this May 2, 2023
castrapel
castrapel previously approved these changes May 2, 2023
Copy link
Contributor

@castrapel castrapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -10.24 ⚠️

Comparison is base (b45c61f) 85.25% compared to head (c51dd62) 75.02%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #371       +/-   ##
===========================================
- Coverage   85.25%   75.02%   -10.24%     
===========================================
  Files          98       98               
  Lines       10624    10624               
===========================================
- Hits         9058     7971     -1087     
- Misses       1566     2653     +1087     
Flag Coverage Δ
functional_tests ?
functional_tests_config_discovery ?
unit_tests 75.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 47 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@castrapel castrapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smoy smoy merged commit 2ec5f68 into main May 2, 2023
4 of 6 checks passed
@smoy smoy deleted the task/policy-statement-condition-example branch May 2, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants