Implemented #390 Tags support on IAMbic hub and spoke role creation #392
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
===========================================
- Coverage 85.28% 75.27% -10.01%
===========================================
Files 98 98
Lines 10612 10648 +36
===========================================
- Hits 9050 8015 -1035
- Misses 1562 2633 +1071
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
|
||
| def parse_pair(s) -> dict: | ||
| key, value = s.rstrip().split("=") | ||
| return {"Key": key, "Value": value} |
There was a problem hiding this comment.
Do we need to do some regex validation on tags? And char limit check? (I feel like we have this type of function somewhere in cloudumi but I can't find it)
There was a problem hiding this comment.
added validate callback in questionnaire. I check aws-cli doesn't actually check on the cli level, and defer regex check on boto3.
|
Tests are failing 😞 |
…reated with iam write access
CHANGELOG.md
Outdated
|
|
||
| THANKS: | ||
|
|
||
| * `noq@phad.me`, `perpil` in [NoqCommunity](https://noqcommunity.slack.com/archives/C02P9E8BDK6/p1683275443604049) proposing tags support during IAMbic setup. |
There was a problem hiding this comment.
Is noq@phad.me formatted properly?
There was a problem hiding this comment.
Gonna use consistent First Name, Last initial since the conversation is from slack. (avoiding mixing Github identities and Slack)
What changed?
Rationale
How was it tested?
If it was manually verified, list the instructions for your reviewers to follow.
Run iambic setup, and iambic import