Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require pre-commit; fix lint issues; update dependencies #409

Closed
wants to merge 4 commits into from

Conversation

castrapel
Copy link
Contributor

This PR does the following:

  • Upgrades dependencies (A recently upgrade of urllib3 appears to cause issues with Poetry on M1 Mac. Upgrading dependencies resolves it),
  • Fixes lint issues found from running pre-commit run -a
  • Runs pre-commit run -a before the unit tests t

@@ -223,16 +220,6 @@ def test_create_templates_for_modified_files_with_multi_account_support(
assert templates[0].properties.name == "after"


def test_create_templates_for_modified_files_with_multi_account_incl_star_support(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of the function below

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (e03f4e6) 85.29% compared to head (e1382cf) 85.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
+ Coverage   85.29%   85.33%   +0.04%     
==========================================
  Files          98       98              
  Lines       10696    10698       +2     
==========================================
+ Hits         9123     9129       +6     
+ Misses       1573     1569       -4     
Flag Coverage Δ
functional_tests 67.19% <50.00%> (+0.39%) ⬆️
functional_tests_config_discovery 47.05% <50.00%> (+<0.01%) ⬆️
unit_tests 75.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iambic/plugins/v0_1_0/aws/template_generation.py 100.00% <100.00%> (ø)
iambic/vendor/lambda_multiprocessing/__init__.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@castrapel
Copy link
Contributor Author

Merged into Will's branch bug/en-2119-fix-merge-model-int-handling

@castrapel castrapel closed this May 15, 2023
@castrapel castrapel deleted the chore/require-pre-commit-update-deps branch May 15, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant