Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EN-2120: remove account's id and name from variables, if empty exclude it #414

Merged
merged 1 commit into from
May 17, 2023

Conversation

JonathanLoscalzo
Copy link
Contributor

What changed?

Exclude account_name and account_id from variables

Rationale

These keys are written in other level, so it is redundant.

How was it tested?

  • Unit Tests
  • Functional Tests
  • Manually Verified: clean repo execute setup

Copy link
Collaborator

@Will-NOQ Will-NOQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -16.65 ⚠️

Comparison is base (8b49a1c) 85.24% compared to head (0b34e6d) 68.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #414       +/-   ##
===========================================
- Coverage   85.24%   68.60%   -16.65%     
===========================================
  Files          98       95        -3     
  Lines       10711    10396      -315     
===========================================
- Hits         9131     7132     -1999     
- Misses       1580     3264     +1684     
Flag Coverage Δ
functional_tests 66.74% <0.00%> (-0.03%) ⬇️
functional_tests_config_discovery 47.02% <100.00%> (-0.03%) ⬇️
unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iambic/plugins/v0_1_0/aws/models.py 82.13% <100.00%> (-4.13%) ⬇️

... and 60 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JonathanLoscalzo JonathanLoscalzo merged commit 71babac into main May 17, 2023
3 of 4 checks passed
@JonathanLoscalzo JonathanLoscalzo deleted the fix/en-2120-hub_role_stack_name branch May 17, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants