Fixed wizard prompt when editing an AWS account. #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castrapel
reviewed
May 16, 2023
| @@ -1002,7 +1002,7 @@ def configuration_wizard_aws_account_edit(self): | |||
| ).unsafe_ask() | |||
| if action == "Go back": | |||
| return | |||
| elif action == "Update name": | |||
| elif action == "Update region": | |||
| account.default_region = set_aws_region( | |||
| "What region should IAMbic use?", account.default_region | |||
| ) | |||
There was a problem hiding this comment.
What about the update_name conditional below?
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 85.24% 85.28% +0.03%
==========================================
Files 98 98
Lines 10711 10711
==========================================
+ Hits 9131 9135 +4
+ Misses 1580 1576 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
How was it tested?
If it was manually verified, list the instructions for your reviewers to follow.