Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #406 pass tags arguments to hub account spoke role creation #416

Merged
merged 1 commit into from
May 17, 2023

Conversation

smoy
Copy link
Contributor

@smoy smoy commented May 17, 2023

What changed?

  • Pass the tags argument into hub_account spoke role creation

Rationale

  • ops, forgot to pass argument into the function.

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (8b49a1c) 85.24% compared to head (4947d13) 85.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   85.24%   85.21%   -0.04%     
==========================================
  Files          98       98              
  Lines       10711    10711              
==========================================
- Hits         9131     9127       -4     
- Misses       1580     1584       +4     
Flag Coverage Δ
functional_tests 67.00% <ø> (+0.23%) ⬆️
functional_tests_config_discovery 47.00% <ø> (-0.05%) ⬇️
unit_tests 75.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iambic/plugins/v0_1_0/aws/cloud_formation/utils.py 16.54% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JonathanLoscalzo JonathanLoscalzo self-requested a review May 17, 2023 12:55
Copy link
Contributor

@JonathanLoscalzo JonathanLoscalzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JonathanLoscalzo JonathanLoscalzo merged commit 61ed269 into main May 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants