-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix detect interpreter #498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the AWS detect handler.
…ovider child. New functions for aggregating detect messages.
…rsive sort on the provider child dicts in base_group_dict_attribute.
…ce_file_for_all_accounts.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
===========================================
- Coverage 85.74% 75.73% -10.02%
===========================================
Files 102 103 +1
Lines 11637 11727 +90
===========================================
- Hits 9978 8881 -1097
- Misses 1659 2846 +1187
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
smoy
reviewed
Jul 18, 2023
…efs] -> list(aws_account_map.values())
smoy
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG FIXES:
ENHANCEMENTS:
base_group_dict_attribute
is now more deterministic in its grouping.iambic detect
performance optimizations.engineering
is on all accounts and detect is ran for account a, onlyengineering
on account a is evaluated.