Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix okta pagination handling on apps, groups, and users #652

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

smoy
Copy link
Contributor

@smoy smoy commented Nov 9, 2023

What changed?

  • Fixed pagination for okta list_applications, list_users, and list_groups

Rationale

  • In pagination, the next_apps|users|groups is type list, instead of append to the existing list, we have to use extend

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified

This is a little tricky since our testing infra does not mock or have mechanism for testing okta pagination and okta test env has limit that does not trigger pagination.

@smoy smoy requested a review from castrapel November 9, 2023 05:08
@ashugart-hazel
Copy link

Validated fix. 🙌🏽

image Screenshot 2023-11-09 at 9 52 48 AM

Copy link
Contributor

@castrapel castrapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@castrapel castrapel merged commit fa3764f into noqdev:main Nov 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants