Added rate limiting for callback or promise usage. Trello limits requ… #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests to its APIs (http://help.trello.com/article/838-api-rate-limits). By default rate limiting is turned off and is set to limit at a single API key and token rate (100 requests per a 10 second interval). Rate limiting is toggled via a static exposed limitRate property on the wrapper object, and rate amounts can be edited via a limits object.
|
Would you please resolve the merge conflicts? |
|
It doesn't looks possible to resolve the conflicts. By the looks of it #43 has solved the same issue (but using a random delay). Implementation details differ enough that both cannot and should not exist together. #43 is a simpler solution without a 3rd party module however doesn't guarantee ordering nor earliest possible execution time (if limit is breached). This PR I believe will guarantee order and execute requests at the earliest possible time (its been a while since I did the PR so can't remember the details 100%). As #43 is in the project I don't mind you closing this PR if you feel that is solving the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been making a bulk uploader into trello, and hit the trello api rate limit. Thought it might be something nice to put into this project so added simple-rate-limiter module (no license and requires node v0.10.1+, project has tests). By default it is turned off, but the config is set at the token/key rate of 100 per 10 second interval. I've made it wrap both callback and promise APIs. There's some tests to check it works both rate limited and non rate limited. Plus updated the README.
If its something you want in the project, feel free to merge.