Add extra params support everywhere #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s not options in the Restler sence, it is just query so I think it’s best to name it that way.
|
The CI failure looks like it might be a Restler failure with Node 4. It's on this line: parsers.xml.options = (typeof options.xml2js == 'undefined') ? {} : options.xml2js;as I don't know why it happens on that one test though ¯_(ツ)_/¯ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #39.
This PR adds the option to adding extra query params to every method without damaging backwards compatibility, by adding an optional
extraParamsargument to every method call (except those that already have one).The tests have not been modified, and all pass. I will add tests for the new style too.