Keep rolling Node.js versions with latest/LTS releases #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the tests are failing for the oldest version of Node.js the test suite runs on. This is version 4.0.0, which was a new version when it was added to the Travis CI config in 2015, but it is now so old that it is no longer supported. Instead of dropping version 4 and adding new versions 12 (LTS) and 13 (latest), this commit uses Travis CI's built-in references: - node (the latest version) - lts/* (the currently supported LTS releases) For details on current LTS support status of different versions, see: https://nodejs.org/en/about/releases/
|
As a side-effect, this also fixes the CI errors we're having in the master branch, reproducible in Node.js version 4.0. The 4.x release reached end of maintenance on 2018-04-30. If this is merged, other recent pull requests (which are all failing) will have to merge/rebase master to include this fix to get working tests again. If we decide we would like to support Node.js version 4.x despite it being unmaintained, we will have to fix the error in the |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the tests are failing for the oldest version of Node.js the test suite runs on. This is version 4.0.0, which was a new version when it was added to the Travis CI config in 2015, but it is now so old that it is no longer supported.
Instead of dropping version 4 and adding new versions 12 (LTS) and 13 (latest), this commit uses Travis CI's built-in references:
node(the latest version)lts/*(the currently supported LTS releases)For details on current LTS support status of different versions, see: https://nodejs.org/en/about/releases/