Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate project to the AceEditorBundle\AceEditorBundle namespace (fixes #74) #75

Merged
merged 4 commits into from Jan 2, 2024

Conversation

nocive
Copy link
Contributor

@nocive nocive commented Dec 27, 2023

Fixes #74

@nocive
Copy link
Contributor Author

nocive commented Dec 27, 2023

cc @norberttech

README.md Outdated Show resolved Hide resolved
@nocive nocive changed the title Migrate project to the NorbertTech\SymfonyAceEditorBundle namespace Migrate project to the NorbertTech\SymfonyAceEditorBundle namespace (fixes #74) Dec 27, 2023
@norberttech
Copy link
Owner

Hey! Sorry I was out for a holidays break 🎅
In general norberttech_ace_editor vs norberttech_symfony_ace_editor shows that using my username in the namespace might not be the best approach. Maybe just AceEditorBundle and then ace_editor ?

@nocive nocive changed the title Migrate project to the NorbertTech\SymfonyAceEditorBundle namespace (fixes #74) Migrate project to the NorbertTech\AceEditorBundle namespace (fixes #74) Jan 2, 2024
@nocive
Copy link
Contributor Author

nocive commented Jan 2, 2024

@norberttech updated. I kept the internal parameters with the norbertech prefix though, as to avoid potential naming collisions with other implementations in the wild.

@norberttech
Copy link
Owner

@norberttech updated. I kept the internal parameters with the norbertech prefix though, as to avoid potential naming collisions with other implementations in the wild.

Are there even any other implementations? 😅 I think I would keep it simple, ace_editor, not sure what would be the use case to have two bundles doing the same thing installed.

README.md Outdated Show resolved Hide resolved
@nocive
Copy link
Contributor Author

nocive commented Jan 2, 2024

Are there even any other implementations? 😅 I think I would keep it simple, ace_editor, not sure what would be the use case to have two bundles doing the same thing installed.

You have no idea what people are capable of 😅

@nocive nocive changed the title Migrate project to the NorbertTech\AceEditorBundle namespace (fixes #74) Migrate project to the AceEditorBundle\AceEditorBundle namespace (fixes #74) Jan 2, 2024
@norberttech
Copy link
Owner

Are there even any other implementations? 😅 I think I would keep it simple, ace_editor, not sure what would be the use case to have two bundles doing the same thing installed.

You have no idea what people are capable of 😅

Hahaha, yeah I have seen things that can't be unseen, but let's not go there, it's an edge case which I don't think is worth our time 😁

@nocive nocive marked this pull request as ready for review January 2, 2024 11:31
@nocive
Copy link
Contributor Author

nocive commented Jan 2, 2024

updated

@norberttech norberttech merged commit c001ec0 into norberttech:5.x Jan 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate project to a different namespace.
2 participants