Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make presentation mode more handy by arrow keys to change slides #43

Conversation

ahmadkadri
Copy link
Contributor

@ahmadkadri ahmadkadri commented Jun 1, 2023

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

Screenshot 2023-06-01 145404

Charly Nguyen and others added 3 commits May 31, 2023 09:26
@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

🦋 Changeset detected

Latest commit: 42da2db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nordeck/matrix-neoboard-widget Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
@ahmadkadri ahmadkadri requested a review from a team June 1, 2023 13:03
@ahmadkadri ahmadkadri marked this pull request as ready for review June 2, 2023 06:14
src/components/PresentBar/PresentBar.tsx Outdated Show resolved Hide resolved
src/components/common/Toolbar/Toolbar.tsx Outdated Show resolved Hide resolved
src/components/common/Toolbar/Toolbar.tsx Outdated Show resolved Hide resolved
src/components/common/Toolbar/Toolbar.tsx Outdated Show resolved Hide resolved
src/components/PresentBar/PresentBar.tsx Outdated Show resolved Hide resolved
fix vertical toolbar keyboard navigation

Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
@nils-nord
Copy link

Test passed.
Tested using Mozilla Firefox & Google Chrome in latest public releases

Copy link
Contributor

@dhenneke dhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only some small comments then this should be ready.

src/components/PresentBar/PresentBar.tsx Outdated Show resolved Hide resolved
src/components/PresentBar/PresentBar.tsx Show resolved Hide resolved
.changeset/four-actors-return.md Outdated Show resolved Hide resolved
Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
@ahmadkadri ahmadkadri requested a review from dhenneke June 2, 2023 10:52
@ahmadkadri ahmadkadri merged commit 535f5e2 into main Jun 5, 2023
4 checks passed
@ahmadkadri ahmadkadri deleted the nic/feat/PB-3363-Make-presentation-mode-more-handy-by-arrow-keys branch June 5, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants