XRDCAT-12: Improve Company and Organization handling processes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job Summary for GradleX-Road-Catalog tests :: BuildAndTest
|
Job Summary for GradleX-Road-Catalog tests :: BuildAndTest
|
petkivim
approved these changes
Jun 14, 2024
| | `xroad-catalog.fetch-external-time-after-hour` | 3 | A parameter for setting the start of time interval during which the X-Road Catalog Collector should try to fetch data from the companies API continuously (this parameter will be ignored if the parameter `xroad-catalog.fetch-companies-run-unlimited` is set to `true`), e.g. value `18` means starting from `18:00`. | | ||
| | `xroad-catalog.fetch-external-time-before-hour` | 4 | A parameter for setting the end of time interval during which the X-Road Catalog Collector should try to fetch data from the companies API continuously (this parameter will be ignored if the parameter `xroad-catalog.fetch-companies-run-unlimited` is set to `true`), e.g. value `23` means ending at `23:00`. | | ||
| | `xroad-catalog.fetch-external-interval-min` | 20 | A parameter for setting the amount of time in minutes after which the X-Road Catalog Collector should start re-fetching data from the external API, e.g. value `20` means `every 20 minutes`. This works together with the following two parameters to determine how often data is checked for staleness and updated in a batch. | | ||
| | `xroad-catalog.fetch-external-limit` | 500 | A parameter for setting the maximum amount of Members that can be fetched from the external API in one run, e.g. value `500` means `500 members`. | |
There was a problem hiding this comment.
For clarity, it would be good to specify if the limit is applied per API or for both APIs together, e.g., 500 Companies + 500 Organizations OR Companies + Organizations = 500.
There was a problem hiding this comment.
Updated the wording to make what happens clearer.
...-collector/src/test/java/fi/vrk/xroad/catalog/collector/tasks/FetchOrganizationTaskTest.java
Show resolved
Hide resolved
...log-collector/src/test/java/fi/vrk/xroad/catalog/collector/tasks/FetchCompaniesTaskTest.java
Show resolved
Hide resolved
|
Job Summary for GradleX-Road-Catalog tests :: BuildAndTest
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.