Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

cordova-hcp deploy copy all the file, should also use chcpignore #49

Closed
dongdh opened this issue Apr 11, 2016 · 11 comments
Closed

cordova-hcp deploy copy all the file, should also use chcpignore #49

dongdh opened this issue Apr 11, 2016 · 11 comments
Labels
Milestone

Comments

@dongdh
Copy link

dongdh commented Apr 11, 2016

cordova-hcp deploy copy all the file, should also use chcpignore

@nikDemyankov
Copy link
Member

Yes, you are correct: it seems deploy doesn't respect the ignore list. At the moment it is used only for the build operation. This should be fixed.

Either way, can you check, that generated chcp.manifest file doesn't contain chcp.manifest in it? It feels like the issue you are having in nordnet/cordova-hot-code-push#133 is because of this.

Just open via browser https://path/to/your/content/chcp.manifest and search for chcp.manifest in it. If it's there - remove it.

@dongdh
Copy link
Author

dongdh commented Apr 19, 2016

ye, the bug is from manifest file in the manifest file, i added it to ignore list, then it worked.

@nikDemyankov
Copy link
Member

Good, thanks. Also, please check, that chcp.json is not in manifest file. These files should be ignored by CLI client by default. Strange, that they are not in your case.

@davidovich
Copy link

@nikDemyankov I have glanced over the code, and if you specify a .chcpigore file, it overrides the default array. see https://github.com/nordnet/cordova-hot-code-push-cli/blob/master/src/context.js#L57

@nikDemyankov
Copy link
Member

@davidovich good catch, thanks :)

@nikDemyankov nikDemyankov added this to the v1.1.0 milestone May 4, 2016
@nikDemyankov
Copy link
Member

Released in v1.1.0. Should now work. If not - please, reopen the issue.

@diegodotta
Copy link

I'm using the v1.1.1 and the deploy doesn't respect the .chcpignore or chcp.manifest.

@nikDemyankov nikDemyankov reopened this May 26, 2016
@nikDemyankov
Copy link
Member

@diegodotta Are you running on Windows machine?

@diegodotta
Copy link

Yes, let me try on mac.

@anthonytvamp
Copy link

I can confirm @diegodotta that I'm using v1.1.1 on Mac and deploy still doesn't respect .chcpignore or chcp.manifest.

@nordnet-deprecation-bot
Copy link
Contributor

👋 Hi! Thank you for your interest in this repo.

😢 We are not using nordnet/cordova-hot-code-push-cli anymore, and we lack the manpower and the experience needed to maintain it. We are aware of the inconveniece that this may cause you. Feel free to use it as is, or create your own fork.

🔒 This will now be closed & locked.

ℹ️ Please see #79 for more information.

@nordnet nordnet locked and limited conversation to collaborators Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants