Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

Made xcodePreferences.js compatible with Cordova v7 #114

Closed
wants to merge 1 commit into from

Conversation

aramando
Copy link

Fix for issue #110

@TianleZhang
Copy link

When can this ticket be merged to master?

@jacquesdev
Copy link

Yup, please merge this and release to npm :)

@majid701
Copy link

@nikDemyankov please merge this pull request. It's needed can't run my ios app without it!

thanks

@newuser44
Copy link

Did this get merged in? Not sure how to tell.

@aramando
Copy link
Author

aramando commented Sep 7, 2017

No, it hasn't been merged, I don't know why; it seems nobody is updating this plugin at the moment.

I would suggest just referencing this commit with the fix as your plugin source instead of the nordnet master. If you're uncomfortable relying on my repository you can always fork it and maintain your own source.

cordova plugin add --save https://github.com/aramando/cordova-universal-links-plugin#35b3ed7e9a0310b12f1ac92a5159b21ce50eee57

@schmidt
Copy link
Contributor

schmidt commented Nov 15, 2017

I needed to add a .git to the Github URL, to make it work. Also --save seems to be the default now.

cordova plugin add https://github.com/aramando/cordova-universal-links-plugin.git#35b3ed7e9a0310b12f1ac92a5159b21ce50eee57

Other than that, I can confirm, that this change works as expected. Thanks for the help.

@florgb02
Copy link

Is there any plans on merging this PR?

Superbil added a commit to karrot-dev/karrot-frontend that referenced this pull request May 8, 2018
@nordnet-deprecation-bot
Copy link
Contributor

👋 Hi! Thank you for your interest in this repo.

😢 We are not using nordnet/cordova-universal-links-plugin anymore, and we lack the manpower and the experience needed to maintain it. We are aware of the inconveniece that this may cause you. Feel free to use it as is, or create your own fork.

🔒 This will now be closed & locked.

ℹ️ Please see #160 for more information.

@nordnet nordnet locked and limited conversation to collaborators Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants