Update manifestWriter.js to fix #133 in Cordova 8. #135
Conversation
Update manifestWriter.js to fix nordnet#133 in Cordova 8.
| @@ -18,7 +18,7 @@ module.exports = { | |||
| * @param {Object} pluginPreferences - plugin preferences as JSON object; already parsed | |||
| */ | |||
| function writePreferences(cordovaContext, pluginPreferences) { | |||
| var pathToManifest = path.join(cordovaContext.opts.projectRoot, 'platforms', 'android', 'AndroidManifest.xml'); | |||
| var pathToManifest = path.join(cordovaContext.opts.projectRoot, 'platforms', 'android', 'app', 'src', 'main', 'AndroidManifest.xml'); | |||
There was a problem hiding this comment.
This change it not backwards compatible and will break build with older Cordova android versions. Maybe you should check the cordova android version or copy the whole manifest file so it is compatible with older project structures.
backwards compatibility for AndroidManifest.xml changes
|
@nordnet-release / @robsan-nordnet 🆘 Hallo guys! any news? we need this changes urgent in master :( because we can not build app with cordova 8 |
|
👋 Hi! Thank you for your interest in this repo. 😢 We are not using nordnet/cordova-universal-links-plugin anymore, and we lack the manpower and the experience needed to maintain it. We are aware of the inconveniece that this may cause you. Feel free to use it as is, or create your own fork. 🔒 This will now be closed & locked. ℹ️ Please see #160 for more information. |
This fix the problem reported in #133. Path to AndroidManifest.xml has changed in Cordova 8.