Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Development): make development base neutral on decimal rounded value #649

Merged
merged 1 commit into from Dec 14, 2018

Conversation

wemstad
Copy link
Contributor

@wemstad wemstad commented Dec 13, 2018

If value is 0.01 but decimal is 1 rendered value becomes 0.0. However,
since the development is still positive the Development component
renders 0.0 in the positive styling. This commit changes this behaviour
and makes the development look at the rendered value rather than the
original value, aligning the design and the displayed value.

If value is 0.01 but decimal is 1 rendered value becomes 0.0. However,
since the development is still positive the Development component
renders 0.0 in the positive styling. This commit changes this behaviour
and makes the development look at the rendered value rather than the
original value, aligning the design and the displayed value.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 99.398% when pulling 282186c on make-development-based-on-decimal-rounding into 0c93f26 on master.

@wemstad wemstad merged commit 370914c into master Dec 14, 2018
@wemstad wemstad deleted the make-development-based-on-decimal-rounding branch December 14, 2018 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants