Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Search component with JSS #142

Merged
merged 4 commits into from Apr 13, 2017
Merged

Search component with JSS #142

merged 4 commits into from Apr 13, 2017

Conversation

willeeklund
Copy link
Contributor

screen shot 2017-04-12 at 17 05 54

@bstream bstream mentioned this pull request Apr 12, 2017
Closed
26 tasks
bstream
bstream reviewed Apr 13, 2017
View reviewed changes
src/components/search/search-styles.jsx
fontSize: '12px',
color: palette.text.default,

'& .flag': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does .flag here really work? Rather send in a custom className to flag and style it here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I added className="flag" to the flag component to be able to style it. Now it works.

bstream
bstream approved these changes Apr 13, 2017
View reviewed changes
Copy link
Contributor

@bstream bstream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bstream bstream merged commit 92d9901 into next Apr 13, 2017
@bstream bstream deleted the feature/search_component_jss branch April 13, 2017 18:18
bstream added a commit that referenced this pull request Apr 20, 2017
@bstream
Next (#160)
8588c52 
* Change webpack and stylegudist configs. Update eslint and styleguidist

* Fix alert styling and tests

* Add correct yarnrc and exclude all logs from git

* Fix typo

* Fix docs styling

* Fix styling with jss

* Add wrapper with ThemeProvider
* Change build to babel
* Modify Badge to work with new styling
* Export Badge and ThemeProvider
* Create test-utils with shallow helper function
* Edit styleguidist config
* Fix tests for Badge

* Remove unused dep

* Add renderToString test helper

* Add mount test helper

* Add tests for ThemeProvider

* Add tests for theme

* Regen yarn.lock

* Remove .only

* Edit Badge to use 'root' instead of 'badge'

* Fix docs publish hook

* 0.2.0-beta.1

* Add JS to labeled value

* Change label font size to 12px

* Add colors and typography

* Remove scss from badge
* Remove rem from badge
* Update colors, palette and theme
* Add typography

* Updated changelog

* 0.2.0-beta.2

* Fix warning color

* Export test-utils and set action in theme

* Updated changelog

* 0.2.0-beta.3

* Fix lint from master

* Fix test-utils export and upgrade enzyme

* 0.2.0-beta.4

* Port text-icon. #121

* Add index.js files to ported icons

* wip

* Logo component with JSS

* Fix the unit test for Logo component

* Better use of JSS in Logo

* Lint fix

* Added updated Flag component using 'clip-path' solution

* Quickfix making table components not rely on scss

* Updated changelog

* Updated changelog with new section

* Export Table related components from index.js

* Properly export components

* Quickfix for components Button, GraphTooltip, HorizontalNav, Legend, Pane

* Export components through index.js files in each folder

* Convert all .svg icons to.jsx

* Remove obsolete babel plugin

* Import NordnetLogo as a jsx module instead of svg file

* Fix unit test

* Import flags as jsx modules

* Update changelog and expose Flag component in index

* Quickfix for Input, Dropdown, Alert, NavBar

* Rename text-icon to avatar. text prop -> child to support other nodes

* Fix tests for avatar

* Fixed review comments

* Fix icon docs

* Fix table docs

* Remove duplicate Flag export

* Fix review feedback

* Fix eslint error

* Fix unit test

* Remove scss import from NavBar

* Updated changelog

* 0.2.0-beta.5

* Remove dependency on src

* Remove dependency on variables

* Updated changelog

* Fix import in Logo

* Fix of validation-icon for Input

* 0.2.0-beta.6

* Fast port tooltip

* Better icon docs

* Fast port Search

* Port SparkGraph

* Fastport Spinner

* Fast port Widget

* Export new components

* Fix changelog and add examples to styleguidist

* Fix warnings in Flag

* Fix warnings in Search

* Fix warnings in Input

* Fix warnings in SparkGraph

* Fast porting RadioGroup, RangeSelector, RatioBar and Select

* Update changelog

* Fix babel-polyfill and replace empty spans with null

* JSS of input-default styles

* JSS of input-select styles

* JSS of styles for InputCheckboxRadio and HelpText

* Update changelog and styleguide config

* Fix stroke colors for ValidationIcon component

* Use px instead of rem

* Use ampersands better in JSS

* Fix unit tests for Input component

* 0.2.0-beta.7

* Review comment fixes

* Temp remove spark-graph because of d3 issues

* Update changelog

* Update changelog 🎉

* 0.2.0-beta.8

* Legend component (#136)

* Legend component using JSS styling

* Remove Legend scss file

* Remove BEM style CSS for Legend

* Move JSS names out to top level for Legend

* Transform Dropdown component to use JSS (#137)

* Transform Dropdown component to use JSS

* Use palette version of primary color

* Dropdown without BEM styling classes

* Move JSS names out to top level for Dropdown

* Add support to pass context to mount helper (#143)

* Pane component to JSS (#138)

* JSS for Pane component

* Remove pane.scss

* Pane without BEM styling classes

* Move JSS names out to top level for Pane

* Horizontal nav JSS (#140)

* Move HorizontalNav to JSS styling, without BEM

* Remove navItem.propTypes because we got an eslint error

* Make changelog and styleguide config with one component per row

* Tooltip jss (#139)

* Tooltip with JSS and without BEM CSS

* Update changelog and styleguide config

* Move JSS names out to top level for Tooltip

* Fix Tooltip hovering support

* Fix tests

* Button component with JSS (#144)

* Search component with JSS (#142)

* Search component with JSS

* Add custom flag class

* Update changelog 🎉

* 0.2.0-beta.9

* Table components with JSS (#145)

* Table components with JSS

* Fix eslint error

* Adjust code styling

* Fix bug with sticky header in tr component

* Widget component to JSS (#146)

* Spinner component with JSS (#147)

* Alert with JSS (#148)

* Port RatioBar to JSS (#150)

* Added Li and Ul components. (#141)

* added Li and Ul components.

* changed colors to use theme. remove redundant stuff.

* added className as props to Li component.

* Cleanup (#152)

* Remove GraphTooltip (See #121)

* Remove Legend (See #121)

* Remove NavBar (See #121)

* Remove RangeSelector (See #121)

* Remove Select (See #121)

* Move NordnetLogo icon to Logo and remove it from Icon (#121)

* Re-structure index and fix styleguidist config

* Remove remainging scss files and rem utility function

* Add transitions to theme and fix input checkbox and radio styles

* Change some variable names

* Remove webpack config

* Remove faulty directories/files from styleguidist

* Fix tests

* Remove shallow-compare in favour of PureComponent

* Remove unused dependencies and bump jss

* Upgrade enzyme

* Change git-directory-deply to gh-pages

* Add in-publish

* Move murmurhash-js to dependencies

* Update jss-theme-reactor

* Fix Li export

* Temporary workaround to fix prop types on input since propsParser seems to not work as intended

* Updated design for Dropdown component (#153)

* Updated design for Dropdown component

* Button design changes (#158)

* Updated font size for LabeledValue (#155)

* Updated font size for LabeledValue

* Eslint fix

* Alert updated design (#156)

* Badge design update (#157)

* Input design changes (#159)

* Fix Icon defaultProps
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bstream bstream bstream approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willeeklund @bstream