Dagster #8
Merged
Dagster #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def get_metadata(self, dbt_resource_props: Mapping[str, Any]) -> Mapping[str, Any]: | ||
| metadata = {"partition_expr": "date"} | ||
| default_metadata = default_metadata_from_dbt_resource_props(dbt_resource_props) | ||
| return {**default_metadata, **metadata} |
There was a problem hiding this comment.
What is this function doing?
In our implementation, we use https://docs.dagster.io/_apidocs/libraries/dagster-dbt#dagster_dbt.DagsterDbtTranslator.get_group_name
I find it personally very nice to teach what a custom translator is doing
There was a problem hiding this comment.
I'm happy you like most of the code; it's @geoHeil 's after all ;)
| ( | ||
| first_partition, | ||
| last_partition, | ||
| ) = context.asset_partitions_time_window_for_output( |
There was a problem hiding this comment.
We use each partition key run and I see for the first time that there is actually a possibility to pack the backfill in one call. I liked that
| @@ -0,0 +1,19 @@ | |||
| {% macro logging_and_variables() %} | |||
| assets=[dbtlearn_dbt_assets, dbtlearn_partitioned_dbt_assets], | ||
| schedules=schedules, | ||
| resources={ | ||
| "dbt": DbtCliResource(project_dir=os.fspath(dbt_project_dir)), |
There was a problem hiding this comment.
Maybe this one can be imported from .constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.