Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed 'colors.search.bar' to 'colors.footer_bar' #25

Closed
wants to merge 2 commits into from
Closed

changed 'colors.search.bar' to 'colors.footer_bar' #25

wants to merge 2 commits into from

Conversation

g3ronymo
Copy link

Alacritty 0.11.0 deprecated 'colors.search.bar' and 'colors.search.footer_bar' should be used instead.

Alacritty 0.11.0 deprecated 'colors.search.bar' and 'colors.search.footer_bar' should be used instead.
Copy link
Member

@svengreb svengreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @g3ronymo 👋, thanks for your contribution 👍

An important difference between deprecations and "deletions" is that deprecations are meant to communicate that a feature/configuration is still supported, but marked for deletion in a later versions. This is a powerful communication method to ensure that users and third-party developers can adapt in time and not being forced to adjust immediately.
This is also important for this theme because not every user want (or can not) update to a latest application version instantly. I've added a code review suggestion to adjust the change.

The change is also not valid because the new key is not part of the search key and you must place it in the colors root key instead so that the full selector is colors.footer_bar and not colors.search.footer_bar.

src/nord.yml Outdated Show resolved Hide resolved
@svengreb svengreb removed their assignment Oct 16, 2022
Co-authored-by: Sven Greb <development@svengreb.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants