Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text invisible in modal overlays #53

Closed
abrthel opened this issue Jan 25, 2017 · 2 comments
Closed

Text invisible in modal overlays #53

abrthel opened this issue Jan 25, 2017 · 2 comments
Labels
type-bug
Milestone
0.10.1

Comments

@abrthel
Copy link

abrthel commented Jan 25, 2017

When trying to create a new file or folder the text in the window doesn't show up. However when I focus on another window other than atom the text in the prompt is visible.

capture

Environment
Atom: v1.13.1
nord-atom-ui: v0.10.0
nord-atom-syntax: v0.6.0
@arcticicestudio arcticicestudio self-assigned this Jan 25, 2017
@arcticicestudio
Copy link
Contributor

Thanks for your report 👍
Seems like this is related to the Atom theme package API changes regarding the shadow DOM removal.
I had to adjust the colors of atom-text-editor[mini] to fix the find-and-replace text box, but it seems like there are edge cases the color must be wrapped into the specific selector class like for this bug it must be wrapped into the modal class.
I'll fix this as soon as possible and release a patch version.

@arcticicestudio arcticicestudio changed the title Text invisible in new file/folder window Text invisible in modal overlays Jan 25, 2017
arcticicestudio added a commit that referenced this issue Jan 25, 2017
@arcticicestudio
GHI-#53 Add new "syntax--" class prefix for text in modal overlays
111fabc
arcticicestudio referenced this issue Jan 25, 2017
@arcticicestudio
Merge branch 'bugfix/ghi-#53-text-invisible-in-modal-overlays' into d…
1598fab 
…evelop
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jan 25, 2017 •
edited
Loading

🚢 Fixed and shipped in apm package release version 🏷 0.10.1.

Before

After

@arcticicestudio arcticicestudio mentioned this issue Jan 25, 2017
Closed
@arcticicestudio arcticicestudio added this to the 0.10.1 milestone Jul 2, 2017
@arcticicestudio arcticicestudio removed their assignment Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug
Projects
None yet
Milestone
0.10.1
Development

No branches or pull requests
2 participants
@abrthel @arcticicestudio