Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packaging fixes #21

Merged
merged 1 commit into from
Mar 26, 2017
Merged

Packaging fixes #21

merged 1 commit into from
Mar 26, 2017

Conversation

purcell
Copy link
Contributor

@purcell purcell commented Mar 26, 2017

  • Format header conventionally, with Commentary and Code section markers
  • Remove redundant use of "Emacs": all elisp packages are for Emacs
  • Declare Emacs 24 dependency
  • Fix typo in "marmalade"
  • Add missing trailing comment line

(In connection with melpa/melpa#4655)

@purcell
Packaging fixes
a393730 
- Format header conventionally, with Commentary and Code section markers
- Remove redundant use of "Emacs": all elisp packages are for Emacs
- Declare Emacs 24 dependency
- Fix typo in "marmalade"
- Add missing trailing comment line
@purcell purcell mentioned this pull request Mar 26, 2017
Merged
4 tasks
@purcell
Copy link
Contributor Author

purcell commented Mar 26, 2017

(P.S. Flycheck and flycheck-package are really helpful for package authors. You can easily create a fresh standard-formatted elisp file using M-x auto-insert.)

@arcticicestudio arcticicestudio mentioned this pull request Mar 26, 2017
Closed
arcticicestudio
arcticicestudio approved these changes Mar 26, 2017
View reviewed changes
Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast reply 👍

@arcticicestudio arcticicestudio merged commit 70a3ee2 into nordtheme:develop Mar 26, 2017
@arcticicestudio arcticicestudio added this to the 0.1.2 milestone Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcticicestudio arcticicestudio arcticicestudio approved these changes

Assignees
No one assigned
Labels
context-documentation type-bug
Projects
None yet
Milestone
0.1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@purcell @arcticicestudio