Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current highlighted line on Terminal not visible #9

Closed
benfrain opened this issue Sep 25, 2019 · 4 comments
Closed

Current highlighted line on Terminal not visible #9

benfrain opened this issue Sep 25, 2019 · 4 comments

Comments

@benfrain
Copy link

benfrain commented Sep 25, 2019

First of all, I love this theme; so hope this can be sorted!

You can see here that the current line doesn't show when using Nord.
Screenshot 2019-09-25 at 12 41 39

If I switch to a default theme such as Solarized it displays fine:

Screenshot 2019-09-25 at 12 44 10

In addition, I noticed the issue in Neovim at first when cycling through search selections. In that case, when pressing n to move to the next match, the selected match would disappear too:

Screenshot 2019-09-25 at 12 37 08

Is this is known issue? Is there any setting I can change in iTerm to fix (running 3.3.4)?

@arcticicestudio
Copy link
Contributor

Hi @benfrain 👋, thanks for your contribution 👍
Are you running nvim within a multiplexer like tmux? These setups require some additional configurations in order to make colors work correctly.
I'll try to reproduce the problem with the current line, but I've also never saw that the current line has a special highlighting. I'll need to check if this is maybe a feature added in later versions.

@benfrain
Copy link
Author

Hi! 👋

No tmux. Just Neovim direct from iterm.

@benfrain
Copy link
Author

benfrain commented Oct 4, 2019

After further investigation, I'm not sure this is to do with Nord iterm2 solely.
I noticed that I don't have this issue using iterm2 on my work computer. So I copied the iterm config json and applied it to my problematic setup and it now works as expected. There is something in the iterm setup that causes this issue.

Here are the working and non-working iterm json configs:

Working: https://gist.github.com/benfrain/11c7b4c6e7cde22348f6f5e6aca64861

Non-working: https://gist.github.com/benfrain/c18fd9bba2dbd56cdbb4c5ef5d25e614

Hopefully that may help reveal the cause of this issue.

@arcticicestudio
Copy link
Contributor

First of all, good that the problem is solved 😄
Thanks for the feedback and the Gists, I've compared both configurations and found 2 possible options that might cause the problem where all of them are included in the non-working set:

Cursor Guide

🔗 Line 478

     "Use Bright Bold": true,
+    "Use Cursor Guide": true,
     "Use Italic Font": true,

I guess this option has the highest probability to be the root cause: The Cursor Guide option

The cursor guide is a horizontal rule that indicates the vertical position of the cursor. You can adjust its color, including alpha value, to make it more visible against your background color.

This is exactly what's visible on your screenshots and I guess it causes problems due to its rendering style using a color value with a alpha layer for opacity.
Also see the documentation section about Cursor Finery that can be enabled when using the block cursor style.

Underline Color

🔗 Line 482

+    "Use Underline Color": false,
     "Vertical Spacing": 1,

It is possible that the Underline Color option also causes problems in combination with the Cursor Guide option when rendering underlined elements.

If enabled, this color will be used for all underlining, independent of the color that underlined characters have themselves.

➡️ You could try to play around with both options to see if this causes the problem again, but I'll also try to reproduce it to maybe include it in the docs/FAQ of this theme.
I close this isseu for now since the problem is resolved, but feel free to post your findings 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants