Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underlined cursor line number in gutter #174

Closed
alexandremjacques opened this issue Sep 30, 2019 · 4 comments · Fixed by #185
Closed

Underlined cursor line number in gutter #174

alexandremjacques opened this issue Sep 30, 2019 · 4 comments · Fixed by #185
Labels
context-ui scope-compatibility scope-ux type-improvement
Milestone
version-0.13.0

Comments

@alexandremjacques
Copy link

Hi,

I'm using Nord theme for VIM 8 on iTerm2 (also using Nord theme) and recently (my guess is after the last major iTerm2 update) I noticed that my line number gutter started appearing underlined on highlight.

Screen Shot 2019-09-29 at 21 22 45

Any ideas how to resolve? I mean, remove the underline from the line number.

Regards.
@arcticicestudio
Copy link
Contributor

Hi @alexandremjacques 👋, thanks for your contribution 👍
Maybe this is also related to nordtheme/iterm2#9. I'll try to reproduce this when updating to the latest iTerm2 version.

@arcticicestudio arcticicestudio self-assigned this Sep 30, 2019
@nixtrace
Copy link

nixtrace commented Oct 7, 2019

This might be related to latest Vim defaulting to underline for CursorLineNr:
https://github.com/vim/vim/blob/017ba07fa2cdc578245618717229444fd50c470d/src/highlight.c#L256

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Oct 7, 2019 •
edited
Loading

@nixtrace Really nice catch 🎉
Comparing with the parent commit shows that the underline attribute was explicitly set for cterm.
The question is if this was done on purpose or should be reported as bug.
If this is a change that'll stay in Vim itself I'll update Nord Vim to explicitly disable the cterm attribute for the CursorLineNr group.

I haven't updated to the latest iTerm2 version yet (only running macOS at my job), but I guess this is superfluous now anyway. I'll also see if this is reproducible on my personal system (Arch Linux) using the latest Vim version.

@nixtrace
Copy link

nixtrace commented Oct 7, 2019

👍 I can see the underline on Arch and Ubuntu running Vim version 8.1.2105. Thanks!

@arcticicestudio arcticicestudio removed their assignment Nov 17, 2019
svengreb pushed a commit that referenced this issue Dec 17, 2019
@arcticicestudio
Remove underline from gutter line numbers
4eff118 
Vim version v8.1.2029 [1] added the `underline` attribute for the
`CursorLineNr` group to `cterm` based on vim/vim#4933 [2].
This change results in gutter line numbers being underlined which has
now been reverted back to Nord's style by explicitly setting the
attribute for the group to `NONE`.

[1]: vim/vim@d9b0d83...017ba07#diff-80fffb3e9c20e93e5b2328a9a20e19c9
[2]: vim/vim#4933

GH-174
@arcticicestudio arcticicestudio added this to the 0.13.0 milestone Dec 17, 2019
@arcticicestudio arcticicestudio mentioned this issue Dec 17, 2019
Merged
arcticicestudio added a commit that referenced this issue Dec 17, 2019
@arcticicestudio
Remove underline from gutter line numbers (#185)
0d352c4 
Vim version 8.1.2029 [1] added the `underline` attribute for the
`CursorLineNr` group to `cterm` [2] based on vim/vim#4933 [3].
This change resulted in gutter line numbers being underlined which has
now been reverted back to Nord's style by explicitly setting the
attribute for the group to `NONE`.

[1]: https://github.com/vim/vim/releases/tag/v8.1.2029
[2]: vim/vim@d9b0d83...017ba07#diff-80fffb3e9c20e93e5b2328a9a20e19c9
[3]: vim/vim#4933

Resolves GH-174
svengreb pushed a commit that referenced this issue Dec 17, 2019
@arcticicestudio
Remove underline from gutter line numbers (#185)
0cca280 
Vim version 8.1.2029 [1] added the `underline` attribute for the
`CursorLineNr` group to `cterm` [2] based on vim/vim#4933 [3].
This change resulted in gutter line numbers being underlined which has
now been reverted back to Nord's style by explicitly setting the
attribute for the group to `NONE`.

[1]: https://github.com/vim/vim/releases/tag/v8.1.2029
[2]: vim/vim@d9b0d83...017ba07#diff-80fffb3e9c20e93e5b2328a9a20e19c9
[3]: vim/vim#4933

Resolves GH-174
defr0std added a commit to defr0std/nord-vim that referenced this issue May 17, 2021
@defr0std @arcticicestudio
@hennessey @vasilescur @alexanderjeurissen @xulongwu4 @svengreb @dmshvetsov @meck
Master (#1)
382759f 
* adds coc error gutter support

* remove duplicated entries

* Update colors/nord.vim

Co-Authored-By: Arctic Ice Studio <development@arcticicestudio.com>

* Fix typo

line 13

* Uniform status lines config for bundled airline and lightline themes (nordtheme#169)

The included theme bundles have not supported the "uniform status line" feature (nordthemeGH-58), which allows to change the background color of the status bar (StatusLine) group to `nord3`.

Related to nordthemeGH-58
Resolves nordthemeGH-168

* Plugin support for `vim-startify` (nordtheme#176)

Added custom highlight groups of the `vim-startify` (1) plugin to adapt
to Nord's style.

References:
  (1) https://github.com/mhinz/vim-startify

Resolves nordthemeGH-159

* Remove underline from gutter line numbers (nordtheme#185)

Vim version 8.1.2029 [1] added the `underline` attribute for the
`CursorLineNr` group to `cterm` [2] based on vim/vim#4933 [3].
This change resulted in gutter line numbers being underlined which has
now been reverted back to Nord's style by explicitly setting the
attribute for the group to `NONE`.

[1]: https://github.com/vim/vim/releases/tag/v8.1.2029
[2]: vim/vim@d9b0d83...017ba07#diff-80fffb3e9c20e93e5b2328a9a20e19c9
[3]: vim/vim#4933

Resolves nordthemeGH-174

* Prepare release version 0.13.0

* adds coc error gutter support

* Add nvim-lsp support (nordtheme#198)

Added highlighting support for the build-in Neovim language server [1] using the coc.nvim [2] groups as reference.

[1]: https://github.com/neovim/nvim-lsp
[2]: https://github.com/neoclide/coc.nvim

* Consistent `Error` and MoreMsg highlight group consistent between console and GUI modes. (nordtheme#202)

Consistent `Error` and `MoreMsg` highligh. in term and GUI mode (nordtheme#202)

Before the `Error` group in GUI mode used `nord0` as foreground color
instead of `nord4` resulting in a bad contrast.

Also after checking  ( links to it)
Also since there was also no color defined for terminal mode for the
`MoreMsg` group (see `:help MoreMsg` that link to `:help more-prompt`)
Vim used the default color which was some kind of green.
To ensure it matches Nord's style it has now been changed to use `nord8`
(main accent color) for both terminal and GUI mode.
This can be tested by running `:echon "MESSAGE\n"` taht produces a lot
of lines that won't fit on the current screen space anymore.

Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
Co-authored-by: Sven Greb <development@svengreb.de>

* Use transparent background for gutter line number in GUI mode (nordtheme#204)

The `LineNr` and `CursorLineNr` highlight groups now have a transparent
background in GUI mode.

Before it was set to `nord0_gui` which worked fine in most cases.
However, some plugins use these highlight groups to render their content
in a popup window which can potentially have a different background
color. This caused some issues e.g. for the fuzzy search plugin
LeaderF [1].

The compatibility with the `g:nord_cursor_line_number_background`
theme configuration has been verified to work as expected in both modes
when it is set to `0` or `1`.

This change is not related to the terminal mode or when using
`set notermguicolors` since `ctermbg` for `LineNr` and `CursorLineNr`
is set to `NONE` by default.

[1]: https://github.com/Yggdroot/LeaderF

* Release version 0.14.0

* adds coc error gutter support

* Add nvim-lsp support (nordtheme#198)

Added highlighting support for the build-in Neovim language server [1] using the coc.nvim [2] groups as reference.

[1]: https://github.com/neovim/nvim-lsp
[2]: https://github.com/neoclide/coc.nvim

* Add basic TypeScript and improve TSX support (nordtheme#208)

Basic highlighting support for TypeScript & TSX

Added basic support to highlight TypeScript & TSX syntax more
consistently through the HerringtonDarkholme/yats.vim plugin [1].
This includes improvements to highlight...

1. ...TypeScript interface an class names using `nord7` as foreground,
   where interfaces also use the bold attribute, to match with
   structs/classes.
2. ...global methods like e.g. `setTimeout` with `nord8` using the
   italic attribute to mark it kind of static. 
3. ...regular expressions with `nord13` as foreground color instead of
   the normal color for quoted strings (`nord14`) to make it easier to
   differ between both. 
4. ...global objects like `Error`, `JSON` and `console` with `nord7`.
5. ...primitive/builtin types like `string` with `nord9`.
6. ...TypeScript type references with `nord7`.
7. ...TypeScript specific characters like for type annotations (`:`) and
   member optionality (`?`) as operator with `nord9`.

This also includes improvements for "vanilla" JavaScript elements.

[1]: https://github.com/HerringtonDarkholme/yats.vim

Resolves nordthemeGH-208

Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
Co-authored-by: Sven Greb <development@svengreb.de>

* Add support for vim-clap (nordtheme#178)

Added basic support for vim-clap [1], a modern and performant generic finder and dispatcher for Vim and NeoVim.

[1]: https://github.com/liuchengxu/vim-clap

nordthemeGH-178

Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
Co-authored-by: Sven Greb <development@svengreb.de>

* Release version 0.15.0

Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
Co-authored-by: john.hennessey <john.hennessey@ef.com>
Co-authored-by: John Hennessey <jghennes@gmail.com>
Co-authored-by: Radu Vasilescu <vasilescur@gmail.com>
Co-authored-by: Jose M. Murinello <jm.murinello@gmail.com>
Co-authored-by: Alexander Jeurissen <1220084+alexanderjeurissen@users.noreply.github.com>
Co-authored-by: xulongwu4 <xulongwu4@gmail.com>
Co-authored-by: Sven Greb <development@svengreb.de>
Co-authored-by: iamdi <helloiamdi@gmail.com>
Co-authored-by: Johan <meck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-ui scope-compatibility scope-ux type-improvement
Projects
None yet
Milestone
version-0.13.0
Development

Successfully merging a pull request may close this issue.

Remove underline from gutter line numbers nordtheme/vim
3 participants
@nixtrace @alexandremjacques @arcticicestudio