Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment contrast #26

Closed
octref opened this issue Mar 4, 2017 · 4 comments
Closed

Comment contrast #26

octref opened this issue Mar 4, 2017 · 4 comments

Comments

@octref
Copy link

octref commented Mar 4, 2017

Feel the comment contrast is a bit too low:

image

I'm setting it to hi Comment ctermfg=14 temporarily, but hope you can resolve it.

image

Not against the idea that comment should be in the same hue as bg, but the contrast needs to be higher.

@arcticicestudio
Copy link
Contributor

👍 Thanks for your proposal, but this change is absolutely against the design idea of Nord.
The low contrast has been selected specifically to not disturb code flow and keep the focus of the developer on the code. Using a color like e.g. nord7 for it would completely mix the separation between the code and comments. nord7 is used for classes/types/interfaces/documentation tags and you would be unable to differ if it is part of the running code or just a comment.

It is totally fine that you not agree to all highlighting color assignments, everyone has different preferences.
If you'd like to stay with nord7 (ctermfg=14, guifg=14) its totally fine and you don't have to change it in the theme file itself, which would be overriden each time you update your plugins.
Just paste this snippet into your ~/.vimrc somewhere before you set the colorscheme via colorscheme nord and than add your custom syntax highlighting rules you want to override for the Nord Vim theme:

augroup nord-overrides
  autocmd!
  autocmd ColorScheme nord highlight Comment ctermfg=14
augroup END

@octref
Copy link
Author

octref commented Mar 5, 2017

I put this as my last sentence...

Not against the idea that comment should be in the same hue as bg, but the contrast needs to be higher.

to not disturb code flow

I respectfully disagree. Well-written comments either improve your reading/grasping of code much faster, and sometimes they are essential to understanding the intent of code.

It's actually pretty close to what I want. I just hope it's a bit lighter/whiter, so it's easier on the eyes.

@octref
Copy link
Author

octref commented Mar 5, 2017

Ended up increasing iTerm 2 minimum contrast:

image

Which increases contrast to make comments more legible.

image

@octref octref closed this as completed Mar 5, 2017
@arcticicestudio
Copy link
Contributor

This is a nice alternative solution which is supported by many popular terminal emulators.
I'll add it to the project wiki 😉

@arcticicestudio arcticicestudio removed their assignment Sep 23, 2017
onigomex pushed a commit to onigomex/dotfiles that referenced this issue Mar 18, 2022
vimrc をスッキリさせる。
コメントはコミットログを残すので、↓ git blame とかで見てね。

"Setting/Tool/arcticicestudio/nord-vim

""Disable diff backgroud color
""diff 時のバックグラウンドカラーは無効化する
let g:nord_uniform_diff_background = 1

""Set bold vertical split line
""垂直分割ラインは、bold にする
let g:nord_bold_vertical_split_line = 1

""Set cursor line number backgroud
""カーソル行番号のバックグラウンドカラーをアクティブにする
let g:nord_cursor_line_number_background = 1

""Visual, CursorLine のカラーを好みに変更する(デフォルトだと見えづらい部分)
- [Comment contrast · Issue #26 · arcticicestudio/nord-vim](://github.com/nordtheme/vim/issues/26)
- [Nord](https://www.nordtheme.com/docs/ports/vim/customization)

augroup ColorschemeNord
  autocmd!
  autocmd ColorScheme nord highlight Visual ctermfg=11
  autocmd ColorScheme nord highlight CursorLine ctermfg=14
augroup END

""Set colorscheme (NOTE: Set at the bottom of the color sheme)
""カラースキーマを設定する ※カラースキーマの中身を設定した後に定義する
colorscheme nord
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants