Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve status line visibility #46

Closed
wants to merge 1 commit into from

Conversation

skrobul
Copy link

@skrobul skrobul commented Aug 23, 2017

I'd like to propose small change in the StatusLine and StatusLineNC colors. In current release, these are practically invisible because they have the same color as background.
If this has been done on purpose, please close this PR.

Before

screen shot 2017-08-23 at 11 39 31 am

After

screen shot 2017-08-23 at 11 45 25 am

Copy link

@francis36012 francis36012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@skrobul
Copy link
Author

skrobul commented Sep 9, 2017

thanks @francis36012 :)

@arcticicestudio
Copy link
Contributor

Thanks for your contribution 👍
Sorry for my late reply, I'm currently busy coding a lot of things for my job. I'll take a look at your changes tomorrow to include it in the next release asap if everything looks fine.

@arcticicestudio
Copy link
Contributor

Alright, I've checked your changes and noticed that this is related to #37. I've already prepared a change/fix for it, but had no time to propose the possible solutions. Your PR would also fix it, but I'd like to involve other users to decide which change would fit the best.

I'll open a poll in #37 so it would be nice if you subscribe to this issue and vote 😄

Copy link
Contributor

@dylnmc dylnmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arcticicestudio
Copy link
Contributor

Superseded by #58

@skrobul Thanks again for your PR, we've superseded it in #58 to make this change configurable. Please feel free to subscribe to this PR and review the changes 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants