Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color setting for support.variable is missing #39

Closed
peterdanis opened this issue Aug 11, 2017 · 1 comment
Closed

Color setting for support.variable is missing #39

peterdanis opened this issue Aug 11, 2017 · 1 comment

Comments

@peterdanis
Copy link

In JS template literals support variables have the same color as strings. For TS setting is there but for JS it is missing.

{
  "name": "[JavaScript] Variables",
  "scope": "source.js support.variable",
  "settings": {
    "foreground": "#D8DEE9"
  }
}

Before:
image

After:
image

@arcticicestudio arcticicestudio added this to the 0.6.0 milestone Sep 24, 2017
@arcticicestudio arcticicestudio self-assigned this Sep 24, 2017
arcticicestudio added a commit that referenced this issue Sep 24, 2017
The punctuation characters are now colorized with nord10. Variable
properties are now using nord4 instead of string colors (nord14).

GH-39
@arcticicestudio
Copy link
Contributor

Thanks for your report 👍

I've created PR #51 which improves the string literal characters and the color of the variable properties.

arcticicestudio added a commit that referenced this issue Sep 26, 2017
…late-literals

Improve JavaScript template literal styles
@arcticicestudio arcticicestudio removed their assignment Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants