Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't highlight Go string format placeholders #7

Closed
jsvensson opened this issue Apr 2, 2017 · 3 comments
Closed

Doesn't highlight Go string format placeholders #7

jsvensson opened this issue Apr 2, 2017 · 3 comments

Comments

@jsvensson
Copy link
Contributor

Version: Nord 0.1.1

The Nord theme is missing colors for constant.other.placeholder.go, which golang uses for Printf (etc) placeholders.

clipboard02

Example of the Solarized theme with the same line of Go code:

clipboard01

I don't really know my way around the theme, but I did a quick test using the escape character color:

clipboard01

<dict>
    <key>name</key>
    <string>[Go] String format placeholder</string>
    <key>scope</key>
    <string>source.go constant.other.placeholder.go</string>
    <key>settings</key>
    <dict>
        <key>foreground</key>
        <string>#EBCB8B</string>
    </dict>
</dict>

Good job on this color scheme, definitely one of my favorites!

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Apr 6, 2017

Implemented in the referenced commit above.

ghi-7-scrot-after

@jsvensson
Copy link
Contributor Author

jsvensson commented May 11, 2017

It seems this change didn't make it into the switch from the tmTheme format to the JSON file.

edit: I'll add it to the JSON and make a PR.

@arcticicestudio
Copy link
Contributor

I've used the builtin converter provided by VS Code to migrate to the new JSON format.
It seems like there have been some problems which are described in #12.

arcticicestudio added a commit that referenced this issue May 11, 2017
#7 Re-add Go string format placeholder
@arcticicestudio arcticicestudio added this to the 0.2.0 milestone Jun 25, 2017
@arcticicestudio arcticicestudio removed their assignment Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants