Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbench theming #8

Closed
skbolton opened this issue Apr 5, 2017 · 8 comments
Closed

Workbench theming #8

skbolton opened this issue Apr 5, 2017 · 8 comments

Comments

@skbolton
Copy link

skbolton commented Apr 5, 2017

Avid user of nord palettes here!
I was wondering if you are putting in any work towards the new workbench theming that is going to come to vscode.
microsoft/vscode#3112

I would love to see nord more integrated into vscode like it is in atom with Nord UI. I would be willing to help you on this as well?

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Apr 5, 2017

I definitely planned to add UI support or, if the VS Code team splits up theming into multiple theme packages like Atom, to create a new UI theme package.
I try to keep up-to-date with relevant VS Code repo issues and also replied in other issues about it:

I scrolled through the issue you linked and it seems like the UI API will be added to the March release.

Yes, we are just wrapping up for the March release and plan to document theming soon. We still expect many changes to the theming API though (color keys) during April.

Maybe I'll wait until the April release is ready so I can update to the whole new theming API I've also mentioned in one of the comments linked above 😄

@octref
Copy link
Contributor

octref commented Apr 5, 2017

@arcticicestudio It'd be great if you could start adapting Nord to the new API after the March release. It seems the new API will be available in Insiders during April.

The "many changes" to the API is a reaction to the feedback VSCode has gotten. So if you need something for Nord that is not available through API yet, you can leave feedback to VSCode and they will probably change the API to adapt needs. This is more work, but it benefits all VSCode theme authors (a better theming API) and makes Nord a well-integrated theme to VSCode.

I'm using Nord for Vim and iTerm, and I really want it for VSCode.
Let me know how I might help.

@nomenon
Copy link

nomenon commented Apr 6, 2017

try this config. Share your config too ))
"workbench.experimental.colorCustomizations": {
"statusBarBackground": "#3B4252",
"inactiveTabBackground": "#3B4252",
"tabBorder": "#262B35",
"inputBoxBackground": "#485264",
"panelBackground": "#485264",
"sideBarBackground": "#3B4252",
"activityBarBackground": "#485264",
"tabsContainerBackground": "#485264",
"peekViewResultsBackground": "#3B4252",
"peekViewTitleBackground": "#3B4252"
},
default

@ghost
Copy link

ghost commented Apr 6, 2017

Thanks I tried it and added "titleBarActiveBackground": "#485264" same for Inactive, but can't find the color option for terminal dropdown menu and intellisense.

@arcticicestudio
Copy link
Contributor

Well, version 1.11 has been released, but they've added this to the changelog:

There are still several gaps and we have not finalized the new theme file format. For that reason, there's no documentation and we ask theme authors to not use the new theme format yet.

Users can set some attributes on their own to adjust the workbench to fit the syntax theme as posted by @nomenon and also mentioned in the changelog:

However, if you want to play around with new colors, use the setting workbench.experimental.colorCustomizations to customize the currently selected theme.

@octref I've added a project card to keep track of the new theming API changes and will start to work on it as soon as the changes are merged into the Insider version for theme authors to adapt the API.

@octref
Copy link
Contributor

octref commented Apr 6, 2017

Sounds great. Really looking forward to next month's release and nord's update :D

@arcticicestudio
Copy link
Contributor

arcticicestudio commented May 1, 2017

🔀 Pull Request: #11

I've created #11 which implements the new workbench theming- and JSON theme format API.
Please feel free to check out 🌱 branch and post improvement suggestions and bugs.
The PR is 👷 work in progress and there are some unresolved tasks. Some of them are blocker which needs to be addressed, maybe someone got more information about it.

arcticicestudio added a commit that referenced this issue May 2, 2017
The "contrastBorder" and "contrastActiveBorder" also effecting the
background of the elements they are applied on.
@fabricioanciaes
Copy link

fabricioanciaes commented May 4, 2017

I also tried to theme the workbench, is not complete but here's my take on it:

"workbench.colorCustomizations": {
    "activityBar.background": "#1e2126",
    "activityBar.foreground": "#ecf0f1",
    "activityBarBadge.foreground": "#ecf0f1",
    "activityBarBadge.background": "#2e3440",
    "sideBar.background": "#272c34",
    "sideBarSectionHeader.background":"#23272d",
    "tab.border": "#23272d",
    "tab.activeBackground":"#2e3440",
    "tab.inactiveBackground":"#23272d",
    "editorGroupHeader.tabsBackground":"#23272d",
    "foreground":"#d8dee9",
    "focusBorder":"#1e2126",
    "panelTitle.activeForeground":"#1e2126",
    "button.background":"#8fbcbb",
    "button.hoverBackground":"#9ecccb",
    "dropdown.background":"#1e2126",
    "dropdown.border":"#2e3440",
    "input.background":"#272c34",
    "editorWidget.background":"#23272d",
    "editorSuggestWidget.border":"#2e3440",
    "statusBar.background":"#141518",
    "statusBar.foreground":"#d8dee9",
    "panel.background":"#23272d",
    "widget.shadow":"#2e3440",
    "editorLineNumber.foreground":"#4c566a",
    "list.hoverBackground":"#252930",
    "list.focusBackground":"#1e2126",
    "list.highlightForeground":"#a3be84",
    "list.inactiveSelectionBackground":"#2e3440",
    "pickerGroup.foreground":"#4c566a",
}

image

arcticicestudio added a commit that referenced this issue May 6, 2017
Now using "nord12" to increase the readability
arcticicestudio added a commit that referenced this issue May 6, 2017
Changed from 75% to 30% to increase the readability.
arcticicestudio added a commit that referenced this issue May 6, 2017
Now using nord1 instead of nord2 to match the background color of
inactive selected list elements.
arcticicestudio added a commit that referenced this issue May 6, 2017
Now using nord8 with 60% transparency to differ from active selected
list elements. This also improves navigating the list using the keyboard.
@arcticicestudio arcticicestudio added this to the 0.2.0 milestone Jun 25, 2017
@arcticicestudio arcticicestudio removed their assignment Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants