Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow revert ice delimiter fix #124

Closed
gold2718 opened this issue Dec 22, 2023 · 2 comments
Closed

Allow revert ice delimiter fix #124

gold2718 opened this issue Dec 22, 2023 · 2 comments
Assignees
@gold2718
Milestone
NorESM2.1

Comments

@gold2718
Copy link

gold2718 commented Dec 22, 2023 •
edited
Loading

Issue Description

The ice delimiter bug correction implemented in response to #110 leaves the model in an unbalanced state that requires tuning to fix. For the NorESM2.1 release, we will leave this correction in the code but include a compile-time option to revert this change so that the results are more in line with the NorESM2.0 release.

Will this change answers?

Yes

Will you be implementing this yourself?

Yes
@gold2718 gold2718 added this to the NorESM2.1 milestone Dec 22, 2023
@gold2718 gold2718 self-assigned this Dec 22, 2023
@MichaelSchulzMETNO
Copy link

hm - Why should the bug be reintroduced? I thought retuning will be suggested after some testing.

@gold2718 gold2718 changed the title Revert ice delimiter fix Allow revert ice delimiter fix Jan 11, 2024
@gold2718 gold2718 mentioned this issue Jan 11, 2024
Merged
gold2718 added a commit that referenced this issue Jan 18, 2024
@gold2718
Merge pull request #125 from gold2718/fix_ice_delimiter_bug_fix
4451aa4 
cam_noresm2_1_v1.0.2: Correct ice delimiter bug fix

Summary: Add a compile-time option to revert the ice delimiter to the NorESM2.0 behavior

Contributors: gold2718

Reviewer: DirkOlivie

Purpose of changes: Allow revert ice delimiter fix (#124)
Also, fix some usermods directories to turn on AEROCOM output as described in the user manual.

Github PR URL: #125

Changes made to build system: None
Changes made to the namelist: None
Changes to the defaults for the boundary datasets: None
Substantial timing or memory changes: None

Added a compile time switch (NORESM2_ICE_DELIMITER) that reverts the ice delimiter behavior to match NorESM2.0.

Tests
    aux_cam_noresm:
        BASELINE failures for NF compsets (expected due to bug fixes and ice delimiter change)
        NLCOMP failure (namelist change) for F2000climo compset due to change in land ice from CISM2%NOEVOLV to SGLC.
    Ran test ERP_D_Ln9_P18.f19_f19.NF1850.betzy_intel.cam-outfrq9s three ways:
        "Default" NorESM2.1 configuration (with ice delimiter fix), compared with version before NorESM2 option (PASS)
        NorESM2.1 configuration modified to use NorESM2.0 ice delimiter (by defining NORESM2_ICE_DELIMITER), compared with NorESM2 code version (substituted NorESM2 version of src/NorESM/micro_mg2_0.F90 -- PASS)
        "Default" NorESM2.1 configuration (with ice delimiter fix), compared with NorESM2 code version (BASELINE FAIL as expected)
@gold2718
Copy link
Author

Resolved by #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gold2718 gold2718

Labels
None yet
Projects
NorESM Development
Status: Done
Milestone
NorESM2.1
Development

No branches or pull requests
2 participants
@gold2718 @MichaelSchulzMETNO