Fix responses

kita/contexts.py

@@ -34,7 +34,7 @@ def __init__(self, event: InteractionCreateEvent, handler: GatewayCommandHandler
         self.handler = handler
         self.last_message: Optional[Message] = None
         self.command: Optional[ICommandCallback] = None
-        self.deferring = True
+        self.deferring = False
 
     def set_command(self: ContextT, command: ICommandCallback) -> ContextT:
         self.command = command

kita/responses.py

@@ -56,12 +56,16 @@ async def execute(self, ctx: Context) -> Optional[Message]:
         interaction = ctx.interaction
         res: Optional[Message] = None
         if self.type == DEFER:
+            if ctx.deferring:
+                return None
+
             await interaction.create_initial_response(
                 ResponseType.DEFERRED_MESSAGE_CREATE
             )
-            ctx.n_message += 1
             ctx.deferring = True
-        elif self.type == CREATE:
+            return None
+
+        if self.type == CREATE:
             if ctx.deferring:
                 self.type = EDIT
                 return await self.execute(ctx)
@@ -78,7 +82,7 @@ async def execute(self, ctx: Context) -> Optional[Message]:
             if ctx.deferring:
                 ctx.deferring = False
 
-            if ctx.n_message == 1:
+            if ctx.n_message < 2:
                 res = await interaction.edit_initial_response(*args, **kwargs)
             else:
                 assert ctx.last_message is not None  # can't be None

nokari/extensions/api.py

@@ -304,9 +304,12 @@ async def spotify_album(
         ctx: Context = data(Context),
         spotify_client: SpotifyClient = data(SpotifyClient),
         album: str = "",
-    ) -> None:
+    ) -> Any:
+        yield defer()
+
         if not album:
-            return await spotify_track(ctx, spotify_client, album=True)
+            yield spotify_track(ctx, spotify_client, album=True)
+            return
 
         if not (spotify_album := await spotify_client.get_item(ctx, album, Album)):
             return
@@ -455,6 +458,8 @@ def rtfd_hikari(
     if not obj:
         return respond(f"{HIKARI_BASE_URL}/hikari")
 
+    yield defer()
+
     if not objects.objects:
         yield objects.init_cache(ctx.app)
 
@@ -481,7 +486,7 @@ def rtfd_hikari(
             )
         )
 
-    return paginator.start()
+    yield paginator.start()
 
 
 @initializer

nokari/extensions/extras/errors.py

@@ -2,6 +2,7 @@
 from typing import Any, Callable, Dict, Type, TypeVar
 
 import hikari
+from black import traceback
 from hikari.interactions.command_interactions import CommandInteraction
 from hikari.messages import MessageFlag
 
@@ -18,7 +19,7 @@
 )
 from kita.events import CommandFailureEvent
 from kita.extensions import listener
-from kita.utils import find
+from kita.utils import find, get_exc_info
 
 _ExcT = TypeVar("_ExcT", bound=Exception)
 
@@ -78,9 +79,9 @@ async def on_error(event: CommandFailureEvent) -> None:
         await event.context.respond(embed=embed, flags=MessageFlag.EPHEMERAL)
 
     _LOGGER.error(
-        "Ignoring exception in command %s",
+        "Ignoring exception in command %s:\n%s",
         event.context.command and event.context.command.__name__,
-        exc_info=error,
+        "".join(traceback.format_exception(*(get_exc_info(error)))),
     )