Backend api improvements #87

norkator · 2020-12-22T19:47:34Z

Draft pr...

Image loading is always copy paste'd from some other route so there is a lot of duplicate code which could be handled via one function.

Improvements

Create imageUtils which is responsible for handling all image loading tasks so that place is centralised. Done
Apply image utils for Cameras route. Done
Apply image utils for Faces route. Done
Apply image utils for History route. Done
Apply image utils for Site route. Done
Apply image utils for Training route. Done
Apply image utils for Wall route. Done

Doing now more overall testing.

norkator added 6 commits December 22, 2020 21:03

Simplifying, adding imageUtils for future use

0b65934

Async await was not working here, tweaking more

565812e

Forgot await

dc5beb2

Tweaking faces api to use imageUtils to have less code

8827e67

Required more tweaking

7acb83f

Notes

46b5bbf

norkator added the enhancement New feature or request label Dec 22, 2020

norkator self-assigned this Dec 22, 2020

norkator added 8 commits December 22, 2020 21:57

Apply imageUtils for History route

a43f6b8

Apply imageUtils for Training route

2b9bc1c

Apply imageUtils for Wall route

998fef2

implement imageUtils for site route

9972520

Accidentally deleted file read

633d92e

Raise count of face grouping images to be loaded

0be5efe

Update training.js

1d93661

Small tweak to fix training route issue loading images

9a36ca5

norkator marked this pull request as ready for review December 23, 2020 18:58

norkator merged commit 045bb0f into master Dec 23, 2020

norkator deleted the backend-api-improvements branch December 23, 2020 20:04

Provide feedback