OkHttp for courier strategies #18
Conversation
Looks good and got response with requested test tracking code
Cainiao worked, tested with real package/tracking number.
Active tracking is broken because server returns You don't have permission to access ... on this server.
Yay! it started to work, url had changed and also needed header changes
No idea does it work but changed url to new one too, getting response but doubting it's working. Needs code for testing.
Working fedex
Postnord had changed their api url too
DHLExpress needed proper headers to work.
| try { | ||
| SSLContext sc = SSLContext.getInstance("SSL"); | ||
| sc.init(null, trustAllCerts, new java.security.SecureRandom()); | ||
| HttpsURLConnection.setDefaultSSLSocketFactory(sc.getSocketFactory()); | ||
| String url = "https://www.r-kioski.fi/wordpress/wp-admin/admin-ajax.php"; |
There was a problem hiding this comment.
Unrelated but maybe add this as a constant for tidyness?
There was a problem hiding this comment.
Like this? c2c3f42
I left those ones intact which parts are constructed like url + tracking number + some latter part
| OkHttpClient client = new OkHttpClient(); | ||
| Request request = new Request.Builder() | ||
| .url(url) | ||
| .addHeader("User-Agent", "Mozilla/5.0") |
There was a problem hiding this comment.
Is there a particular reason for this UA string to be different than the one for ArraPakettiStrategy? Could it be a constant somew
There was a problem hiding this comment.
a42b595 how about now? same agent, tested to be working. As this kind of constant, is it okay?
| } | ||
| // Close connection | ||
| in.close(); | ||
| String url = "https://www.dhl.com/DatPublic/search.do?autoSearch=true&l=fi&directDownload=XML&statusHistory=true&search=consignmentId&a=" + parcelCode; |
There was a problem hiding this comment.
Should I make part "https://www.dhl.com/DatPublic/search.do?autoSearch=true&l=fi&directDownload=XML&statusHistory=true&search=consignmentId&a=" private static final string? and then later append url + parcelCode? is that what you mean?
There was a problem hiding this comment.
Didn't check so carefully but yep it'd more consistent.
|
At first glance looks good 😎. |
All of them are tested except GLS