-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add status code to response content of send request method #165
add status code to response content of send request method #165
Conversation
Hello, thank you for your contribution. I'm not sure that this would be the right way to expose status code. Because if OneSignal would return that field with some other data then you'd have dead code. |
Hi @norkunas, thank you for your answer. I can rename the key to 'http-code' or something more specific to prevent loosing data. |
Maybe |
Hi @norkunas it appears that the validation is blocked by php cs fixer and/or phpstan. Do you have any infos about that ? |
Could you try to amend or force push to retrigger CI? |
651b0b4
to
456edec
Compare
Hi again @norkunas, can you approve the merge ? Thank you in advance |
Hey, you didn't answer my one question yet :) also please squash your commits |
Sorry, it slipped my mind. We need to call many onesignal apps and we want to retrieve the error status to analyze the cause of failure more easily |
All right, so please squash your commits and I'll merge 😉 |
456edec
to
bae261b
Compare
Hello @norkunas i hope you're doing ok :) Is my MR ready to be approved ? Thank you |
Hi, you still got a merge commit, which should not be there :) |
05c4e5c
to
af7be4c
Compare
It should be ok now ;) |
Thank you |
Thanks, you too |
Hello @norkunas, I added the http status code in the sendRequest method for better handle of the api responses. Thank you :)