Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_subscription_ids support to NotificationResolver.php #173

Merged
merged 13 commits into from
Oct 3, 2023
Merged

Add include_subscription_ids support to NotificationResolver.php #173

merged 13 commits into from
Oct 3, 2023

Conversation

metaseller
Copy link
Contributor

Parameter include_player_ids is deprecated now for create notification (see https://documentation.onesignal.com/reference/create-notification#send-to-specific-devices).

It replaced by include_subscription_ids

@norkunas
Copy link
Owner

norkunas commented Oct 2, 2023

Thanks, can you run cs-fixer?

@metaseller
Copy link
Contributor Author

Thanks, can you run cs-fixer?

./vendor/bin/php-cs-fixer fix --config .php-cs-fixer.dist.php

Like this ? Sure

@metaseller
Copy link
Contributor Author

auto cs-fixer removes "empty" phpDocs with {@inheritdoc} and conflicts with php stan. I make some manual phpDoc changes to pass all checks

@norkunas
Copy link
Owner

norkunas commented Oct 3, 2023

auto cs-fixer removes "empty" phpDocs with {@inheritdoc} and conflicts with php stan.

For this reason I use no_superfluous_phpdoc_tags rule in projects, but okay as is. Thank you!

@norkunas norkunas merged commit f7298c5 into norkunas:master Oct 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants