-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add include_subscription_ids support to NotificationResolver.php #173
Add include_subscription_ids support to NotificationResolver.php #173
Conversation
Thanks, can you run cs-fixer? |
Like this ? Sure |
auto cs-fixer removes "empty" phpDocs with {@inheritdoc} and conflicts with php stan. I make some manual phpDoc changes to pass all checks |
For this reason I use no_superfluous_phpdoc_tags rule in projects, but okay as is. Thank you! |
Parameter include_player_ids is deprecated now for create notification (see https://documentation.onesignal.com/reference/create-notification#send-to-specific-devices).
It replaced by include_subscription_ids