Fixed csvExport method #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tixastronauta you should fix only the URL and leave app_id as a query parameter. anyway thanks |
|
@tixastronauta Will you finish this? |
|
Sorry @norkunas I will only be back on Monday. But from what I can tell, my PR is according to the documentation: https://documentation.onesignal.com/reference#csv-export App ID is a header, not a query string. |
|
I talked with support and they said that both choices are supported so for
consistency I've moved to query string.
2016-12-02 20:59 "tixastronauta" <notifications@github.com> rašė:
… Sorry @norkunas <https://github.com/norkunas> I will only be back on
Monday. But from what I can tell, my PR is according to the documentation:
https://documentation.onesignal.com/reference#csv-export
App ID is a header, not a query string.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACmMOFQbYmxu2z4vhu059JtVgAb8RN5mks5rEGp7gaJpZM4LAGpA>
.
|
|
@norkunas done 😄 |
|
@tixastronauta thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method
csvExportgot broken on v0.1.10. It was working fine on v0.1.9.