Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable static boost linkage by default #530

Merged
merged 10 commits into from Nov 2, 2023

Conversation

KernelA
Copy link
Contributor

@KernelA KernelA commented Oct 30, 2023

There are some problems with compiling python package and static boost according to this issue #515.

This pull request contains follow changes:

  1. Boost static linkage is off by default.
  2. pyproject.toml instead setup.cfgsetup.cfg was deprecated.
  3. Some notes about complication with boost.
  4. Run workflow for pull requests to develop branch.

@KernelA KernelA marked this pull request as ready for review October 30, 2023 15:05
@boxanm boxanm self-assigned this Oct 30, 2023
@boxanm boxanm self-requested a review October 31, 2023 10:18
@boxanm
Copy link
Collaborator

boxanm commented Oct 31, 2023

Thanks and good job @KernelA ! Can you please check that the Allow edits from maintainers (see https://i.stack.imgur.com/wu4Wd.png) checkbox is checked? I added a couple of changes to the Python module installation guide that I'd like to add to this PR.

@KernelA
Copy link
Contributor Author

KernelA commented Oct 31, 2023

@boxanm , i see only this

image

@RedLeader962
Copy link
Collaborator

@KernelA @boxanm I've added all four Compile python package github action to the develop branch protection rule until I have time to add the python binding test logic to the libpointmatcher-build-system.

@boxanm boxanm merged commit 90b4a49 into norlab-ulaval:develop Nov 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants